Skip to content

Alar2 modifications#3153

Merged
qwordy merged 4 commits intoAzure:masterfrom
malachma:alar2-modifications
Mar 30, 2021
Merged

Alar2 modifications#3153
qwordy merged 4 commits intoAzure:masterfrom
malachma:alar2-modifications

Conversation

@malachma
Copy link
Member

@malachma malachma commented Mar 12, 2021

This PR is required for PR "Azure/repair-script-library#13" as the current vm-repair extension needs to be modified to add the build tools at deployment time with the help of a cloud-init script.

@yungezz yungezz requested a review from haagha March 15, 2021 02:05
qwordy
qwordy reviewed Mar 15, 2021
View reviewed changes
src/vm-repair/azext_vm_repair/scripts/linux-build_setup-cloud-init.txt
Comment on lines +1 to +2
#cloud-config
# cloud-init script to setup the build environment for alar2
Copy link
Member

@qwordy qwordy Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#cloud-config
# cloud-init script to setup the build environment for alar2
# cloud-config
# cloud-init script to setup the build environment for alar2

Copy link
Member Author

@malachma malachma Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first line in the script for cloud-init has a special meaning. In this case we say that we want to use a cloud-config data script. #could-config is not a comment instead it had to be treated as a statement. Like a macro in C.
The suggested code change does break the code therefore.

Copy link
Member

@qwordy qwordy Mar 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thank you!

@qwordy
Copy link
Member

qwordy commented Mar 15, 2021

@malachma What is Alar2

@qwordy
Copy link
Member

qwordy commented Mar 16, 2021

Please fix the following errors

/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/custom.py:69:36: E126 continuation line over-indented for hanging indent
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/custom.py:69:215: E202 whitespace before ')'
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/custom.py:72:36: E126 continuation line over-indented for hanging indent
/home/vsts/work/1/s/src/vm-repair/azext_vm_repair/repair_utils.py:26:1: E302 expected 2 blank lines, found 1
2     E126 continuation line over-indented for hanging indent
1     E202 whitespace before ')'
1     E302 expected 2 blank lines, found 1

@malachma
Copy link
Member Author

malachma commented Mar 29, 2021

We have 3 build errors which are reported to have failed. The log messages don't allow me to understand where exactly the issue is raised and why. Could this please be further investigated.

@qwordy
Copy link
Member

qwordy commented Mar 29, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 29, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@qwordy
Copy link
Member

qwordy commented Mar 29, 2021

We have 3 build errors which are reported to have failed. The log messages don't allow me to understand where exactly the issue is raised and why. Could this please be further investigated.

I can't see logs. It's gone. I reran them.

@malachma
Copy link
Member Author

malachma commented Mar 29, 2021

Thanks for running the build-test again.

@qwordy qwordy merged commit ed374f9 into Azure:master Mar 30, 2021
@malachma malachma deleted the alar2-modifications branch May 28, 2021 09:40
@malachma malachma mentioned this pull request Jun 18, 2021
Merged
3 tasks
zhoxing-ms pushed a commit that referenced this pull request Jul 29, 2021
@malachma
Set version to 0.3.6 (#3518)
54b11ed 
* Set version to 0.3.6

This update is necessary for PR #3153

* Added az-vm-repair to the file to trigger the CI job.

* changed "vm repair" to "vm-repair"

* Added HISTORY.rst

* Added missing command "vm-repair" and updated its URL

* HISTORY.rst is used by setup.py now. Added package-data "linux-build_setup-cloud-init.txt"

* merged manually missing object for arcdata

* Update service_name.json

fixed the linter complain about a missing newline

* Add missing newline at end of file. Complained by linter

* Add missing Command "vm"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haagha haagha Awaiting requested review from haagha

1 more reviewer

@qwordy qwordy qwordy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@qwordy qwordy

Labels

extension/vm-repair

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malachma @qwordy @yungezz